Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low test coverage #30

Open
mohamed82008 opened this issue Feb 16, 2020 · 0 comments
Open

Low test coverage #30

mohamed82008 opened this issue Feb 16, 2020 · 0 comments

Comments

@mohamed82008
Copy link
Member

Currently the test coverage is pretty low. Some of the functions defined here are used in packages downstream so we get indirect testing, but this is not good enough for CI. I went through the coverage report and found the following missing tests:

  • unsafe_cholesky
  • For
  • TuringWishart and TuringInverseWishart
    • insupport
    • size
    • rank
    • mean
    • mode
    • meanlogdet
    • entropy
    • cov
    • var
    • rand
    • Constructor with df::TrackedReal and S::Matrix
  • TuringDenseMvNormal
    • length
    • rand
    • Matrix logpdf
  • TuringDiagMvNormal
    • params
    • dim
    • size
    • rand
  • TuringScalMvNormal
    • length
    • size
    • Single and multi rand
  • TuringMvLogNormal
    • length
    • Single and multi rand
    • Vector and matrix logpdf out of support
    • Constructor with m::TrackedVector or m::AbstractVector and A::UniformScaling
  • TuringUniform
    • No arg constructor
    • logpdf of Distributions.Uniform with x::TrackedReal
  • Semicircle
    • logpdf of Distributions.Semicircle with x::TrackedReal
  • inv of pi
  • NegativeBinomial
    • nbinomlogpdf - not sure why because we are testing NegativeBinomial and this should be called
  • TuringPoissonBinomial
    • quantile
    • minimum

Let's make the coverage 100%!

@mohamed82008 mohamed82008 changed the title Low coverage Low test coverage Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant