Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous style and docs improvements #622

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Jun 18, 2024

Small typo fixes and a couple of docstring improvements. These are things I picked up as I was reading the code to understand it.

@coveralls
Copy link

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9563441562

Details

  • 5 of 10 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 79.623%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/context_implementations.jl 0 5 0.0%
Totals Coverage Status
Change from base Build 9495604846: -0.7%
Covered Lines: 2743
Relevant Lines: 3445

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9563441562

Details

  • 5 of 10 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 80.326%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/context_implementations.jl 0 5 0.0%
Totals Coverage Status
Change from base Build 9495604846: -0.03%
Covered Lines: 2756
Relevant Lines: 3431

💛 - Coveralls

@torfjelde
Copy link
Member

Note that there's quite a rework on the transformation side in the works: #575 . I started working on this again today. After that, vectorize will be replaced + not used as extensively. You can see a description in the doc-preview: https://turinglang.org/DynamicPPL.jl/previews/PR575/internals/transformations/

@mhauru mhauru self-assigned this Sep 2, 2024
@mhauru mhauru force-pushed the mhauru/misc-style-improvements branch from e979b42 to 5c2a625 Compare September 2, 2024 15:38
@mhauru
Copy link
Member Author

mhauru commented Sep 2, 2024

I rebase this on master and left only the relevant changes. Ready for review now.

@mhauru mhauru marked this pull request as ready for review September 2, 2024 15:40
@coveralls
Copy link

coveralls commented Sep 2, 2024

Pull Request Test Coverage Report for Build 10669973054

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 77.508%

Files with Coverage Reduction New Missed Lines %
src/model.jl 1 88.46%
src/threadsafe.jl 18 49.57%
Totals Coverage Status
Change from base Build 10652412131: 0.0%
Covered Lines: 2712
Relevant Lines: 3499

💛 - Coveralls

@yebai yebai enabled auto-merge September 2, 2024 18:34
@yebai yebai added this pull request to the merge queue Sep 2, 2024
Merged via the queue into master with commit 3ffb003 Sep 2, 2024
11 of 12 checks passed
@yebai yebai deleted the mhauru/misc-style-improvements branch September 2, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants