Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error and reorder some functions in the MCMCChain extension #650

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

sunxd3
Copy link
Collaborator

@sunxd3 sunxd3 commented Sep 4, 2024

error is: vn is not an argument to function _check_varname_indexing

also reorder some functions for readability

@sunxd3 sunxd3 requested review from yebai and mhauru September 4, 2024 10:27
@coveralls
Copy link

coveralls commented Sep 4, 2024

Pull Request Test Coverage Report for Build 10699843039

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 77.508%

Files with Coverage Reduction New Missed Lines %
ext/DynamicPPLMCMCChainsExt.jl 1 81.82%
Totals Coverage Status
Change from base Build 10672167384: 0.0%
Covered Lines: 2712
Relevant Lines: 3499

💛 - Coveralls

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.66%. Comparing base (3ffb003) to head (e449873).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #650      +/-   ##
==========================================
+ Coverage   75.95%   76.66%   +0.71%     
==========================================
  Files          29       29              
  Lines        3518     3518              
==========================================
+ Hits         2672     2697      +25     
+ Misses        846      821      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhauru mhauru added this pull request to the merge queue Sep 4, 2024
Merged via the queue into master with commit bf73fd0 Sep 4, 2024
13 of 14 checks passed
@mhauru mhauru deleted the sunxd/patch-sep-4 branch September 4, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants