[Bug] Light Level Calculated incorrectly for low Stealth and negative perception

[philipandresen]

Barony/src/entity.cpp

Lines 895 to 899 in 33b568c

	if ( sneaking )
	{
	light /= 2; // halve for sneaking
	}
	light -= (light - TOUCHRANGE) * (1.0 * (myStats.PROFICIENCIES[PRO_STEALTH] / 100.0)); // reduce to 32 as sneak approaches 100

Evaluate this expression with minimum light (48) touch range (32) and stealth skill of zero. No observer or observer perception is zero

if ( sneaking ){ 48 /= 2; } // == 24
24 -= (24 - 32) * (1.0 * (0 / 100.0)); // 24 - (-8 * 0) = 24
// Visibility is 24

Evaluate with minimum light (48) touch range (32) and stealth skill of 100. No observer or observer perception is zero

if ( sneaking ){ 48 /= 2; } // == 24
24 -= (24 - 32) * (1.0 * (100 / 100.0)); // 24 - (-8 * 1) = 24 + 8 = 32
// Visibility is 32

This also makes enemies with negative perception scores give odd values - with higher stealth giving you worse ability to hide.

That's the bug report!

I submitted a fix here along with a refactor. I have a feeling this bug exists because this code is particularly confusing, so a refactor seemed appropriate.
#805