Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth Issues #9

Open
15 tasks done
aliaagheisX opened this issue Oct 25, 2023 · 1 comment
Open
15 tasks done

Auth Issues #9

aliaagheisX opened this issue Oct 25, 2023 · 1 comment

Comments

@aliaagheisX
Copy link
Contributor

aliaagheisX commented Oct 25, 2023 •
edited
Loading

  • GenerateToken should have user data as payload not only id
  • CreateNewUser replaced name signup *if createUser shouldn't set auth
  • GetUset replaced name loing *if getUser shouldn't set auth
  • Signup & Login shouldn't return all user data
  • move Signup & Login to auth
  • unifying function names
  • FORMATTER
  • signup add validation
  • login move validation logic into its place
  • any file have one export => should have same name
  • add api documentation to signup forget password
  • add api documentation to login
  • integrate emailVerification in signup
  • signup should check if email, username are valid even if there's api check for that
  • refactor cookie parsing
@aliaagheisX
Copy link
Contributor Author

aliaagheisX commented Oct 27, 2023 •
edited
Loading

@Sara-Gamal1 could you work on login documentation before handing it to cross-platform team tomorrow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aliaagheisX @EmanElbedwihy