Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerting): Overriding telegram id and token #717

Closed
sbriskin opened this issue Mar 30, 2024 · 4 comments
Closed

feat(alerting): Overriding telegram id and token #717

sbriskin opened this issue Mar 30, 2024 · 4 comments
Labels
area/alerting Related to alerting feature New feature or request good first issue Good for newcomers

Comments

@sbriskin
Copy link

sbriskin commented Mar 30, 2024

Describe the feature request

Add support for overriding telegram recipients and bots. Something like this:

alerting:
  telegram:
    token: "NNNNNNNNN:xxxxxxx_yyyyyyyyy"
    id: "123456789"
    overrides:
      - group: "A"
        id: "-1009876543210"
      - group: "B"
        id: "-1001234567890"
        token: "NNNNNNNNN:aaaaaaaaa_bbbbbbbb"

Why do you personally want this feature to be implemented?

This is amazing app, but only one telegram id limit makes me cry.
I have a few telegram chats: one for devops team with their ci resources, one for QA with their test servers and one only for myself for other tasks. So I have to manually forward notifications from my personal chat to others. Please add override rules for telegram.

How long have you been using this project?

No response

Additional information

No response

@TwiN TwiN added feature New feature or request good first issue Good for newcomers area/alerting Related to alerting labels Mar 30, 2024
@TwiN
Copy link
Owner

TwiN commented Mar 30, 2024

If anybody that wants to pick this up, here's 2 examples of the work needed: #272 #292

@lefes
Copy link
Contributor

lefes commented Jul 26, 2024

@TwiN Thank you for providing these examples. They were helpful for me in preparing the PR. I hope it passes your review. If needed, I will make any necessary fixes promptly and stay in touch.

@lefes
Copy link
Contributor

lefes commented Jul 30, 2024

@TwiN, I believe this issue can be closed. Would you agree?

@TwiN
Copy link
Owner

TwiN commented Jul 30, 2024

Yep, you're right @lefes!

Resolved by #826

@TwiN TwiN closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Related to alerting feature New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants