Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple languages #49

Closed
leozz37 opened this issue Feb 17, 2023 · 4 comments
Closed

Support for multiple languages #49

leozz37 opened this issue Feb 17, 2023 · 4 comments

Comments

@leozz37
Copy link

leozz37 commented Feb 17, 2023

Describe the feature request

Would be cool if we have support for multiple languages! I'm down to write it for Portuguese and Spanish.

Why do you personally want this feature to be implemented?

Have multi-language in one library

How long have you been using this project?

No response

Additional information

No response

@TwiN
Copy link
Owner

TwiN commented Feb 18, 2023

I wouldn't mind adding packages (e.g. under dictionaries/<lang>/dictionary.go) so that users could selectively import language-specific dictionaries through WithCustomDictionary(...), but the thing is that right now, UTF-8 isn't fully supported (see #47 and #43).

First, we'd have to add support for UTF-8, and then we can safely add support for other languages.

@leozz37
Copy link
Author

leozz37 commented Feb 27, 2023

Awesome! When UTF-8 is supported we can reopen this.

@leozz37 leozz37 closed this as completed Feb 27, 2023
@AlexanderMatveev
Copy link

Any update on this? 🥲

@TwiN
Copy link
Owner

TwiN commented May 21, 2023

@AlexanderMatveev Feel free to open a PR if you'd like to give implementing this a shot.

I had given it a quick try a month or so ago and it wasn't as trivial as I anticipated & I don't have the time to work on this at the moment, but I'll review/merge it if somebody wants to tackle the challenge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants