You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently oidn provides OIDNBuffer, but we do not expose this, instead only providing vectors to interact with the api. It could be useful to expose a wrapper around these (and provide a similar api that took these instead). This could have the previous functions emulated (by directly writing to the buffer like done now).
If as_raw and from_raw functions are also added, users would be able to use the interoperability with graphical apis or these oidn functions could be provided (though I'm not sure safety could be guaranteed, so they would have to be unsafe)
The changes could look something like
pubfnalbedo(&mutself,albedo:&[f32])
to
// different name so the other function can still existpubfnset_albedo_buffer(&mutself,albedo:&Buffer)
I think exposing this would make sense, and could help applications reduce data copies of their images since the current slice APIs will all copy the data into the filter's buffer member: https://github.com/Twinklebear/oidn-rs/blob/master/src/filter.rs#L86-L100 . If the app could provide an OIDN buffer instead, we wouldn't need to make this copy
Currently oidn provides
OIDNBuffer
, but we do not expose this, instead only providing vectors to interact with the api. It could be useful to expose a wrapper around these (and provide a similar api that took these instead). This could have the previous functions emulated (by directly writing to the buffer like done now).If
as_raw
andfrom_raw
functions are also added, users would be able to use the interoperability with graphical apis or these oidn functions could be provided (though I'm not sure safety could be guaranteed, so they would have to beunsafe
)The changes could look something like
to
where the buffer is something like
The text was updated successfully, but these errors were encountered: