-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add further expiration options #65
base: master
Are you sure you want to change the base?
Conversation
Ok, I understand the value of the commit, but it needs some work. First, it's way too many options for a standard installation. We want the first experience to be simple. Secondly, if somebody has another taste than you, he will have to do what you did : edit the code. Can you add a loop in the template, looping on the DURATIONS settings ? Human readable text can be extracted by splitting the dictionary key on the underscore. |
You'll probably need to cast it to a tuple list with items(), sort it, json it then include it in the < head > |
Any news on this ? It just need some configurability to be accepted. |
If you don't feel like doing it, put it on another branch, make another PR, and I'll do it. |
|
@@ -18,8 +18,22 @@ class Paste(object): | |||
DIR_CACHE = set() | |||
|
|||
DURATIONS = { | |||
u'10_mins': 10 * 60, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
datetime.timedelta(minutes=10).seconds
Any progress on this? |
Nope.
Le 23/03/2019 à 07:43, Mhowser a écrit :
… Any progress on this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#65 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/ABmK3hvD1Amo22M1AFjXjCX4zeHsHFnIks5vZc0YgaJpZM4Bwrth>.
|
Resolves #58