Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging to release-5.3: Update 5.3.6 (#5668) #5673

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Merging to release-5.3: Update 5.3.6 (#5668) #5673

merged 2 commits into from
Oct 25, 2024

Conversation

buger
Copy link
Member

@buger buger commented Oct 25, 2024 •
edited by github-actions bot
Loading

User description

Update 5.3.6 (#5668)

  • update

  • Update version-5.3.md

Co-authored-by: Master sharadregoti15@gmail.com

PR Type

Documentation

Description

  • Removed the section detailing the strengthened RBAC password reset permissions from the Tyk Dashboard release notes for version 5.3.
  • Deleted information about a privilege escalation vulnerability fix related to password reset permissions.

Changes walkthrough 📝

Relevant files
Documentation
version-5.3.md
Remove RBAC Password Reset Permissions from Release Notes

tyk-docs/content/product-stack/tyk-dashboard/release-notes/version-5.3.md

  • Removed section on RBAC password reset permissions.
  • Deleted details about privilege escalation vulnerability fix.
    		•  +1/-15   

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @Eopayemi
    Update 5.3.6 (#5668)
    ed0cfd7 
    * update

* Update version-5.3.md

---------

Co-authored-by: Master <sharadregoti15@gmail.com>

(cherry picked from commit f1bc40d)
    @netlify Netlify
    Copy link

    netlify bot commented Oct 25, 2024 •
    edited
    Loading

    ✅ PS. Pls add /docs/nightly to the end of url

    Name Link
    🔨 Latest commit ed0cfd7
    🔍 Latest deploy log https://app.netlify.com/sites/tyk-docs/deploys/671bb8421c95150008ae8742
    😎 Deploy Preview https://deploy-preview-5673--tyk-docs.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @netlify Netlify
    Copy link

    netlify bot commented Oct 25, 2024 •
    edited
    Loading

    ✅ PS. Pls add /docs/nightly to the end of url

    Name Link
    🔨 Latest commit caf2295
    🔍 Latest deploy log https://app.netlify.com/sites/tyk-docs/deploys/671bbaccbf9e9f0008f9140a
    😎 Deploy Preview https://deploy-preview-5673--tyk-docs.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @sharadregoti sharadregoti marked this pull request as ready for review October 25, 2024 15:35
    @sharadregoti sharadregoti enabled auto-merge (squash) October 25, 2024 15:36
    @github-actions GitHub Actions
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis 🔶

    5668 - Partially compliant

    Fully compliant requirements:

    • Remove the section detailing the strengthened RBAC password reset permissions from the Tyk Dashboard release notes for version 5.3.
    • Delete information about a privilege escalation vulnerability fix related to password reset permissions.

    Not compliant requirements:

    • Add a preview link to the PR description.
    • Review the suggestions made by the AI (PR Agent) and update them accordingly.
    • Review and follow the guidelines for contributing to the repository.
    • Read the technical guidelines for contributing to the repository.
    • Start changes off the latest master.
    • Label the PR appropriately.
    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @github-actions GitHub Actions
    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @sharadregoti sharadregoti merged commit 9dce034 into release-5.3 Oct 25, 2024
    10 checks passed
    @sharadregoti sharadregoti deleted the merge/release-5.3/f1bc40d3dec579abbb8e386d8510b222ea94274c branch October 25, 2024 15:37
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @sharadregoti sharadregoti sharadregoti approved these changes

    Assignees
    No one assigned
    Labels
    Review effort [1-5]: 2
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @buger @sharadregoti @Eopayemi