Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkipUserInfoRequest not working #114

Closed
sredxny opened this issue Jul 15, 2020 · 2 comments
Closed

SkipUserInfoRequest not working #114

sredxny opened this issue Jul 15, 2020 · 2 comments
Assignees
Labels

Comments

@sredxny
Copy link
Contributor

sredxny commented Jul 15, 2020

Branch/Environment

  • Branch: e.g. Master/v0.7.0
  • Environment: All

Describe the bug
The value SkipUserInfoRequest is not used correctly and the request to get the user information is triggered everytime, basically we can create a profile and set this value but later the method TAProvider.Init is not doing anything with it, and this value should be assigned to gProv.SkipUserInfoRequest in the Init method of the social Provider.

Reproduction steps
Steps to reproduce the behavior:

  1. Create a social provider for openid-connect
  2. Under ProviderConfig.UseProviders.SkipUserInfoRequest set the value to true
  3. Use the profile
  4. The request to get user info is being triggered even SkipUserInfoRequest is set to true

Actual behavior
The request to fetch user info is being triggered everytime

Expected behavior
The request to fetch user info should be triggered only when SkipUserInfoRequest is false.

Screenshots/Video
If applicable, add screenshots or video to help explain your problem.

Browser/Os (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@sredxny
Copy link
Contributor Author

sredxny commented Jul 23, 2020

this was fixed in cfaffee

the bug lives in v0.7.0 and v0.7.1 but it was fixed in master.

@ilijabojanovic
Copy link
Member

Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants