-
Notifications
You must be signed in to change notification settings - Fork 42
[TT-7086] Add hostNetwork option in helm chart #532
Comments
Thank you for raising this issue @rdcwaldrop1! I will add this ticket in our backlog and keep you posted about it's progress. We also welcome community PRs in case you are interested! |
Great! Thanks @komalsukhani. I'd be happy to take a crack at a PR to add this. |
I've added a draft PR with my thinking on the change to enable hostNetwork mode. The PR template asks to describe testing, but I'm not seeing any automated tests in the repo for helm. Typically how is testing for helm changes handled in this repo? Is there a better place to ask this question? |
@rdcwaldrop1 you are right, we do not have any testing for helm changes for tyk-operator yet. You can create your PR and once your PR is approved, we can test your PR internally and then merge it. |
Thanks @buraksekili for your feedback here and on the PR. I'll take a look at the process you explained and update the PR accordingly. 🙇 |
Expected Behavior
Given our current ENI Configuration in Amazon EKS we need to run the Tyk Operator deployment with hostNetwork mode set to true. I'd like to be able to specify this as a boolean toggle in the values file.
Potential BDD Test Coverage
Current Behavior
The current helm chart provides no means to update the hostNetwork value so I am unable to configure this without editing the underlying template. I'd like to bring this chart in as a helm dependency and not have to edit the template.
Possible Solution
A small block could be added here to set hostNetwork mode equal to .Values.hostNetwork mode or a default of false
Additional Context
The text was updated successfully, but these errors were encountered: