[TT-13107] [release-5.6] remove verbose error log #6531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍
|
|
API Changes no api changes detected |
PR Code Suggestions ✨No code suggestions found for the PR. |
|
titpetric
deleted the
fix/tt-13107/release-5.6-remove-verbose-error-log
branch
|
/release to release-5.6.0 |
|
Working on it! Note that it can take a few minutes. |
tykbot bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
### **User description** https://tyktech.atlassian.net/browse/TT-13107 ___ ### **PR Type** Bug fix ___ ### **Description** - Removed a verbose error log message in `RedisQuotaExceeded` function when the quota is disabled (quota max <= 0). - This change simplifies the logging and avoids unnecessary error messages when the quota is intentionally set to be disabled. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>session_manager.go</strong><dd><code>Remove verbose error logging for disabled quota</code> </dd></summary> <hr> gateway/session_manager.go <li>Removed verbose error logging when quota is disabled.<br> <li> Simplified the logic for handling quota limits.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6531/files#diff-e6b40a285464cd86736e970c4c0b320b44c75b18b363d38c200e9a9d36cdabb6">+0/-1</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions Co-authored-by: Tit Petric <tit@tyk.io> (cherry picked from commit 0324505)
|
@titpetric Succesfully merged PR |
lghiur
pushed a commit
that referenced
this pull request
Sep 19, 2024
…or log (#6531) (#6552) [TT-13107] [release-5.6] remove verbose error log (#6531) ### **User description** https://tyktech.atlassian.net/browse/TT-13107 ___ ### **PR Type** Bug fix ___ ### **Description** - Removed a verbose error log message in `RedisQuotaExceeded` function when the quota is disabled (quota max <= 0). - This change simplifies the logging and avoids unnecessary error messages when the quota is intentionally set to be disabled. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>session_manager.go</strong><dd><code>Remove verbose error logging for disabled quota</code> </dd></summary> <hr> gateway/session_manager.go <li>Removed verbose error logging when quota is disabled.<br> <li> Simplified the logic for handling quota limits.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6531/files#diff-e6b40a285464cd86736e970c4c0b320b44c75b18b363d38c200e9a9d36cdabb6">+0/-1</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions Co-authored-by: Tit Petric <tit@tyk.io> [TT-13107]: https://tyktech.atlassian.net/browse/TT-13107?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: Tit Petric <tit.petric@monotek.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
https://tyktech.atlassian.net/browse/TT-13107
PR Type
Bug fix
Description
RedisQuotaExceededfunction when the quota is disabled (quota max <= 0).Changes walkthrough 📝
session_manager.go
Remove verbose error logging for disabled quotagateway/session_manager.go