[TT-12814] Make schema more flexible, don't enforce additionalProperties: false #6640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bot and I 👍 this PR title. 🤖 |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
|
API Changes no api changes detected |
lghiur
approved these changes
Oct 15, 2024
|
titpetric
deleted the
fix/tt-12814/relax-schema-strictness-for-compatibility
branch
|
/release to release-5.3 |
|
Working on it! Note that it can take a few minutes. |
tykbot bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
…ies: false (#6640) <details open> <summary><a href="https://tyktech.atlassian.net/browse/TT-12814" title="TT-12814" target="_blank">TT-12814</a></summary> <br /> <table> <tr> <th>Summary</th> <td>Make OAS JSON schema more flexible (do not enforce additionalProperties)</td> </tr> <tr> <th>Type</th> <td> <img alt="Bug" src="https://tyktech.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium" /> Bug </td> </tr> <tr> <th>Status</th> <td>In Dev</td> </tr> <tr> <th>Points</th> <td>N/A</td> </tr> <tr> <th>Labels</th> <td>-</td> </tr> </table> </details> <!-- do not remove this marker as it will break jira-lint's functionality. added_by_jira_lint --> --- https://tyktech.atlassian.net/browse/TT-12814 ___ Enhancement ___ - Removed `additionalProperties: false` from multiple object definitions in the JSON schema to enhance flexibility. - This change allows additional properties in the schema, making it more compatible and less strict. ___ <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>x-tyk-api-gateway.json</strong><dd><code>Relax schema strictness by removing `additionalProperties: false`</code></dd></summary> <hr> apidef/oas/schema/x-tyk-api-gateway.json <li>Removed <code>additionalProperties: false</code> from multiple object definitions.<br> <li> Enhanced flexibility of the JSON schema by allowing additional <br>properties.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6640/files#diff-78828969c0c04cc1a776dfc93a8bad3c499a8c83e6169f83e96d090bed3e7dd0">+1/-73</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information Co-authored-by: Tit Petric <tit@tyk.io> (cherry picked from commit 35500ee)
|
@titpetric Succesfully merged PR |
titpetric
pushed a commit
that referenced
this pull request
Oct 15, 2024
…nforce additionalProperties: false (#6640) (#6641) [TT-12814] Make schema more flexible, don't enforce additionalProperties: false (#6640) ### **User description** <details open> <summary><a href="https://tyktech.atlassian.net/browse/TT-12814" title="TT-12814" target="_blank">TT-12814</a></summary> <br /> <table> <tr> <th>Summary</th> <td>Make OAS JSON schema more flexible (do not enforce additionalProperties)</td> </tr> <tr> <th>Type</th> <td> <img alt="Bug" src="https://tyktech.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium" /> Bug </td> </tr> <tr> <th>Status</th> <td>In Dev</td> </tr> <tr> <th>Points</th> <td>N/A</td> </tr> <tr> <th>Labels</th> <td>-</td> </tr> </table> </details> <!-- do not remove this marker as it will break jira-lint's functionality. added_by_jira_lint --> --- https://tyktech.atlassian.net/browse/TT-12814 ___ ### **PR Type** Enhancement ___ ### **Description** - Removed `additionalProperties: false` from multiple object definitions in the JSON schema to enhance flexibility. - This change allows additional properties in the schema, making it more compatible and less strict. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>x-tyk-api-gateway.json</strong><dd><code>Relax schema strictness by removing `additionalProperties: false`</code></dd></summary> <hr> apidef/oas/schema/x-tyk-api-gateway.json <li>Removed <code>additionalProperties: false</code> from multiple object definitions.<br> <li> Enhanced flexibility of the JSON schema by allowing additional <br>properties.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6640/files#diff-78828969c0c04cc1a776dfc93a8bad3c499a8c83e6169f83e96d090bed3e7dd0">+1/-73</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information Co-authored-by: Tit Petric <tit@tyk.io> [TT-12814]: https://tyktech.atlassian.net/browse/TT-12814?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: Tit Petric <tit@tyk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
TT-12814
https://tyktech.atlassian.net/browse/TT-12814
PR Type
Enhancement
Description
additionalProperties: falsefrom multiple object definitions in the JSON schema to enhance flexibility.Changes walkthrough 📝
x-tyk-api-gateway.json
Relax schema strictness by removing `additionalProperties: false`apidef/oas/schema/x-tyk-api-gateway.json
additionalProperties: falsefrom multiple object definitions.properties.