Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnValueChangedAttribute 在 IMGUI 下不会生效 #90

Closed
Lx34r opened this issue Oct 16, 2024 · 3 comments
Closed

OnValueChangedAttribute 在 IMGUI 下不会生效 #90

Lx34r opened this issue Oct 16, 2024 · 3 comments
Assignees
@TylerTemp
Labels
bug Something isn't working

Comments

@Lx34r
Copy link
Contributor

Lx34r commented Oct 16, 2024

OnValueChangedAttributeDrawer.OnPropertyEndImGui 的前置判断需要onGUIPayload.changed，但是SaintsPropertyDrawer.OnGUI从未对此赋值，就不单独提pr了。

image
image
@TylerTemp TylerTemp self-assigned this Oct 16, 2024
@TylerTemp TylerTemp added the bug Something isn't working label Oct 16, 2024
@TylerTemp
Copy link
Owner

... 应该是 if (error == "")...

应该是某次重构Util.GetValue时写飞了。项目越来越大，我的工作环境主要在 UI Toolkit，有些IMGUI的BUG还真一下发现不了（所以当初为毛要写两套…只能怪Unity的IMGUI无法兼容UI Toolkit了…）

我提一下…感谢指出，不然这个BUG要好久才会被发现。

@TylerTemp
Copy link
Owner

感谢支持，已更新到 3.4.2

@Lx34r
Copy link
Contributor Author

Lx34r commented Oct 16, 2024 •
edited
Loading

我也主要使用UITK，正好今天写编辑器脚本省事只重写了OnInspectorGUI，发现OnGUI居然没触发OnValueChanged回调...
UITK下的SaintsField是真的好用，hack做自定义样式修改也方便，感谢~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TylerTemp TylerTemp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TylerTemp @Lx34r