Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAccs of some operations seem to be omitted #126

Open
cyh767 opened this issue Mar 29, 2022 · 1 comment
Open

MAccs of some operations seem to be omitted #126

cyh767 opened this issue Mar 29, 2022 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@cyh767
Copy link

cyh767 commented Mar 29, 2022 •
edited
Loading

Hi,

I find torchinfo seems omit the MAccs of some operations like torch.mul and torch.matmul. Is it some feature-to-be-added, or we do not need to count these operations when calculating MAccs?

Thank you for help.
@TylerYep
Copy link
Owner

Torchinfo currently does not support counting MACs of these raw operations. The current implementation has a lot of room for improvement: https://github.com/TylerYep/torchinfo/blob/main/torchinfo/layer_info.py#L188

PRs addng or improving this functionality are welcome!

@TylerYep TylerYep added good first issue Good for newcomers help wanted Extra attention is needed and removed good first issue Good for newcomers labels Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TylerYep @cyh767