-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for parsing optional properties (class & interface) #80
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #80 +/- ##
===========================================
+ Coverage 90.22% 90.23% +0.01%
===========================================
Files 63 63
Lines 972 973 +1
Branches 192 172 -20
===========================================
+ Hits 877 878 +1
Misses 88 88
Partials 7 7
Continue to review full report at Codecov.
|
I am not sure what caused fail check in CI. @buehler can you please check this pull request and accept it if possible, please? (or tell me what is wrong) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
Nice, but there are tests missing ;-) maybe that is why the codecov check fails. Can you add a test for an optional property?
Yes I can :) I am just little bit confused where to put the tests' code. Can you tell me how to create new test in project's structure? (/test folder seems quite complex to me :) ) |
I can and I will, but first I'm gonna finish my holiday :-) I'll be back in 1 week. |
hmm I could add the PR and add the tests by myself so you get an example. I'll write the reference in this PR as a response for you. |
Add tests for isOptional properties and methods (#80) and the same flag to methods.
This merge adds new flag
optional
to PropertyDeclaration.It is true for TS properties defined optional e.g. { myProperty?: string }