Installing atom-typescript does not disable built-in language-typescript

[ghost]

I installed atom-typescript and was suprised some features didn't work (for example auto import). The reason is there are 2 different kind of Typescript Syntax Highlights, build-in package language-typescript and atom-typescript (this one). I believe if a user install atom-typescript, language-typescript should be disabled, otherwise it becomes very confusing. Reference #549 (comment) and #1344

[lierdakil]

Well, that's certainly weird. And relatively recent. I haven't noticed that. Thanks for letting us know.

Although, it's an open question whether we should disable built-in grammar. Maybe we should just drop our grammar and just use a built-in one. @guncha, any thoughts?

[lierdakil]

Actually, it'd be rather hard for us to disable any package on installation, since we activate only when typescript grammar is used. Huh. This is a more difficult problem than I thought. Using Atom's bundled grammar seems more lucrative by the minute. @guncha, let me ask again: what do you think about dropping our grammar and using Atom's builtin instead?

[taylon]

I personally think that using the builtin grammar is the way to go, I don't see the reason for duplication specially because the grammar might be useful without atom-typescript, someone using atom-ide for example will use the builtin grammar and won't use atom-typescript.

Also the grammar for Typescript in Atom (both builtin and atom-typescript) is currently really really bad compared to VSCode for example. If we concentrate the grammar in one place we have the potential to deliver improvements for all atom users independently of whether or not they are using atom-typescript.

[lierdakil]

someone using atom-ide

That's just GUI. You still need backend, like atom-typescript or ide-typescript. So, irrelevant.

grammar for Typescript in Atom (both builtin and atom-typescript) is currently really really bad compared to VSCode for example

Both our and builtin grammars are basically carbon copies of Microsoft's TypeScript grammar for TextMate. Until Atom supports other grammar models besides TextMate (which it hopefully will soon-ish, there has been some good work done on that), we're stuck with that.

[taylon]

That's just GUI. You still need backend, like atom-typescript or ide-typescript. So, irrelevant.

I was obviously mentioning people using atom-ide with ide-typescript =D

Both our and builtin grammars are basically carbon copies of Microsoft's TypeScript grammar for TextMate. Until Atom supports other grammar models besides TextMate (which it hopefully will soon-ish, there has been some good work done on that), we're stuck with that.

Makes sense, but my point is about the fact that today if we improve the builtin grammar by updating it from Microsoft's repo or like the PR I did a couple of days ago (atom/language-typescript#13) atom-typescript users don't benefit.

[lierdakil]

So we're now (since v12) using the language-typescript package that ships with Atom. Thanks for your input everyone.