Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import require completion regexp incomplete #807

Closed
blakeembrey opened this issue Jan 5, 2016 · 1 comment
Closed

Import require completion regexp incomplete #807

blakeembrey opened this issue Jan 5, 2016 · 1 comment
Labels

Comments

@blakeembrey
Copy link
Member

Noticed it while reviewing #805, but the regexp \w+ isn't 100% complete for valid JavaScript identifiers. For instance, a $ is allowed (also various UTF8 characters). Maybe there's something that exists for this, I know I've done the same RegExp in a number of other projects.

@github-actions
Copy link

github-actions bot commented Jan 4, 2020

This issue has been marked as stale because it did not have any activity for the last 90 days or more. Remove the stale label or comment or this will be closed in 14 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant