fix: bring back :line:col format in webpack errors #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robcrocombe
force-pushed
the
fix/error-format-2
branch
from
def9e77 to
588a8a2
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Reimplements TypeStrong#489 so that file links with locations can be clicked in the terminal.
robcrocombe
force-pushed
the
fix/error-format-2
branch
from
588a8a2 to
81ef6e6
Compare
piotr-oles
approved these changes
May 1, 2022
|
🎉 This PR is included in version 7.2.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks @piotr-oles! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! In 2020 I opened an issue (#481) and subsequent PR (#489) to make error file names clickable with their line location intact, when you use cmd+click in a terminal like iTerm2. E.g. before it was
filename.ts 12:5but we changed it tofilename.ts:12:5to make it one item without space delimiters. This is a huge win for productivity as you don't need to hunt down the line number after opening the file.I noticed while upgrading to v7 that this behaviour has been reverted by #641. It was mentioned in the GH issue that developer experience was more important than following Webpack convention. Has the stance changed on this or was it just a mistake?
If so, I've made this PR to bring back the clickable location behaviour. If not, is there another way we can fix this? I noticed there was a custom
formatteroption but that does not allow you to format the file name, and I still want to use codeframe. Thanks