fix: #775 node_modules not ignored.

[annitya]

The logic has been taken form this post.

On windows the "node_modules"-entry in the excluded array is absolute and looks something like this: "c:\\users\\..". The path that is tested is in unix-format. The string-test startsWith fails to account for this.

I grabbed the code from StackOverflow, tested it directly by editing the compiled version of this plugin, modified it and added it here. It's late and I'm tired, so take a few extra looks at the logic. Our app would hang for about 30s, seemingly doing nothing after webpack was done compiling. It now starts instantly.

[piotr-oles]

Thanks for fixing that! Please add unit tests and extract the code so it's easier to understand the logic :)

[piotr-oles]

Please extract this code to a separate function and file.

// src/utils/path/is-inside-another-path.ts
import { relative, isAbsolute } from 'path';

function isInsideAnotherPath(path: string, anotherPath: string): boolean {
  const relativePath = relative(anotherPath, path);
  
  return relativePath && !relativePath.startsWith('..') && !isAbsolute(relativePath);
}

export { isInsideAnotherPath };

and write some unit tests for this function :)

[annitya]

I'll see what I can do. I don't have much spare time at the moment, so I don't know when I'll be able to make the necessary adjustments.

[annitya]

'aight! I fixed it up a little.

[piotr-oles]

Thanks for the changes, looks good 👍

[piotr-oles]

Looks like it doesn't work on linux and macos :)

[annitya]

Looks like it doesn't work on linux and macos :)

Can't even trust StackOverFlow? What's the world coming to... I'll take a look!

[piotr-oles]

Yeah, AFAIK, path behavior is platform specific unless you use path.win32 or path.posix

[annitya]

I modified the tests to use the platform-specific implementation. I reasoned that if you are matching against win32-paths when on Unix, something else entirely has gone majorly wrong.

[github-actions]

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[annitya]

Thanks for merging!

Tested the changes today. At first it didn't work, but then I found out why.
TypeScript-exclude supports glob-patterns, but the custom-matcher in fork-ts-checker-webpack-plugin does not. The logic is complex and while it's tempting to reuse, rather than recreate, the API is marked as internal.

On a positive note, globs never worked, so it's not worse than before. Thoughts?