fix: issue-webpack-error should not add colors to file string #825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #641, the issue location is now coloured in green in both the terminal console and in the error sent to webpack.
No problem at all in the terminal:
Having a look at the message sent through ws:
The file property contains the ANSI chalk chars corresponding to the colour applied to the issue location.
The thing is, in the webpack-dev-server overlay, the location does not come up properly:
In fact, the overlay does not seem to apply a ANSI to HTML conversion for the header of the message (file) (see. overlay.js#L247) but only for the body of the message (message) (see. overlay.js#L262).
I suggest that we just remove the coloured location in the error message sent to webpack.
Here is a minimum reproducible example:
https://github.com/sreucherand/webpack-ts-checker-minimal-reproducible-example