Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appendTsSuffixTo, path in error messages #1331

Closed
SimmeNilsson opened this issue May 27, 2021 · 2 comments
Closed

appendTsSuffixTo, path in error messages #1331

SimmeNilsson opened this issue May 27, 2021 · 2 comments
Labels

Comments

@SimmeNilsson
Copy link

SimmeNilsson commented May 27, 2021

Expected Behaviour

Error logs referencing actual file on file system (not file with .ts appended).

Actual Behaviour

appendTsSuffixTo makes paths in error message point to non-existent file.

ERROR in C:\DeveloperArea\Troubleshooting\vue_ts\MyComponent.vue.ts
17:12-18
[tsl] ERROR in C:\DeveloperArea\Troubleshooting\vue_ts\MyComponent.vue.ts(17,13)
TS2552: Cannot find name 'onCick'. Did you mean 'onClick'?

I understand that it is supposed to add ts-suffix internally.
But including the suffix in the error output means one can't click them in, for example VS Code, and end up at the place of the error.

Steps to Reproduce the Problem

Download repo
yarn
yarn build

See file path in build error

Location of a Minimal Repository that Demonstrates the Issue.

https://github.com/SimmeNilsson/vue_ts

Additional info

Line numbers would still be off.
But added workaround from vuejs/vue-loader#1778 to get correct ones.

@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 17, 2022
@stale
Copy link

stale bot commented Apr 28, 2022

Closing as stale. Please reopen if you'd like to work on this further.

@stale stale bot closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant