Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore option docs unclear; should point out they're regexps #1089

Open
Tracked by #1317
cspotcode opened this issue Jul 29, 2020 · 2 comments
Open
Tracked by #1317

ignore option docs unclear; should point out they're regexps #1089

cspotcode opened this issue Jul 29, 2020 · 2 comments
Labels
documentation you can do this Good candidate for a pull request.

Comments

@cspotcode
Copy link
Collaborator

cspotcode commented Jul 29, 2020

It's not clear that the ignore option is an array of regexps which are passed to new RegExp. I think we can be clearer about this.

Whatever docs update we make for this will also address #1063

EDIT: also the schema default value is wrong. Default is a string but should be an array.

@cspotcode cspotcode mentioned this issue Oct 11, 2021
17 tasks
@cspotcode cspotcode added the you can do this Good candidate for a pull request. label Oct 13, 2021
@panchoroo
Copy link

Is this issue still open? Is it referring to this documentation here: https://github.com/TypeStrong/ts-node/blob/main/README.md#ignore-by-regexp?

@andrewmedhurst
Copy link

@cspotcode Based on these comments, it would appear that the appropriate documentation has been completed by you in this PR: https://github.com/TypeStrong/ts-node/pull/1155/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80. If there are no additional changes needed to the documentation, it would appear that this issue is safe to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation you can do this Good candidate for a pull request.
Projects
None yet
Development

No branches or pull requests

3 participants