-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Register
to Service
; re-export as Register
for backwards…
#1158
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1158 +/- ##
==========================================
- Coverage 79.60% 79.33% -0.27%
==========================================
Files 7 11 +4
Lines 711 755 +44
Branches 158 157 -1
==========================================
+ Hits 566 599 +33
- Misses 89 101 +12
+ Partials 56 55 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
src/index.ts
Outdated
@@ -1024,7 +1031,7 @@ function registerExtensions ( | |||
*/ | |||
function registerExtension ( | |||
ext: string, | |||
register: Register, | |||
register: Service, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename this variable too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good catch.
Based on conversation here: #1121 (comment)
create()
will create aService
.register()
will create and register it into the node runtime. But the object itself is not really aRegister
(noun), it's aService
which handles compilation.Other names could be
Compiler
,TsNodeCompiler
, orCompiler
?