Update to latest copy-paste of node's ESM resolve implementation #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resolve-implementation
Codecov Report
@@ Coverage Diff @@
## master #1167 +/- ##
==========================================
- Coverage 79.68% 79.33% -0.36%
==========================================
Files 7 11 +4
Lines 709 755 +46
Branches 157 157
==========================================
+ Hits 565 599 +34
- Misses 89 101 +12
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…ing package.json exports field
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy-pasted the latest ESM resolve implementation from node v15.3.0, applied our diff of changes on top of it, and fixed as necessary.
I had to copy a bit more of node's code, and in the process I split it up into more files to keep things organized.
Node's ESM resolver responds to a new
--experimental-policyflag, but I disabled it to avoid copy-pasting some policy code. I expect node will stabilize this feature over time, eventually exposing the APIs we need to avoid copy-pasting.