Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate possible bugs in top-level-await tests #1696

Closed
cspotcode opened this issue Mar 20, 2022 · 2 comments
Closed

Investigate possible bugs in top-level-await tests #1696

cspotcode opened this issue Mar 20, 2022 · 2 comments

Comments

@cspotcode
Copy link
Collaborator

@ejose19 Can I get a review of our top-level-await tests from you, since you wrote the initial implementation?

In the original PR for top-level await:
https://github.com/TypeStrong/ts-node/pull/1383/files

I see a couple things I'm unclear on:

When running upstream tests, we do not await, so I think failures will be ignored:
https://github.com/TypeStrong/ts-node/pull/1383/files#diff-1d9efcccb250238d73480e5c49afae61494dd3103e9a16c38d36979f27c6ff90R2165

When calling runAndWait we also do not await. Why is that?
In nodejs's tests, there is await

@cspotcode cspotcode changed the title Investigate bugging top-level-await testing Investigate possible bugs in top-level-await testing Mar 20, 2022
@cspotcode cspotcode changed the title Investigate possible bugs in top-level-await testing Investigate possible bugs in top-level-await tests Mar 20, 2022
@cspotcode
Copy link
Collaborator Author

I think I fixed these issues in #1677

@cspotcode
Copy link
Collaborator Author

When running upstream tests, we do not await, so I think failures will be ignored

Looking at this again, it appears the missing await was on some prototype code that perhaps should be deleted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant