We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@ejose19 Can I get a review of our top-level-await tests from you, since you wrote the initial implementation?
In the original PR for top-level await: https://github.com/TypeStrong/ts-node/pull/1383/files
I see a couple things I'm unclear on:
When running upstream tests, we do not await, so I think failures will be ignored: https://github.com/TypeStrong/ts-node/pull/1383/files#diff-1d9efcccb250238d73480e5c49afae61494dd3103e9a16c38d36979f27c6ff90R2165
await
When calling runAndWait we also do not await. Why is that? In nodejs's tests, there is await
runAndWait
The text was updated successfully, but these errors were encountered:
I think I fixed these issues in #1677
Sorry, something went wrong.
When running upstream tests, we do not await, so I think failures will be ignored
Looking at this again, it appears the missing await was on some prototype code that perhaps should be deleted?
No branches or pull requests
@ejose19 Can I get a review of our top-level-await tests from you, since you wrote the initial implementation?
In the original PR for top-level await:
https://github.com/TypeStrong/ts-node/pull/1383/files
I see a couple things I'm unclear on:
When running upstream tests, we do not
await
, so I think failures will be ignored:https://github.com/TypeStrong/ts-node/pull/1383/files#diff-1d9efcccb250238d73480e5c49afae61494dd3103e9a16c38d36979f27c6ff90R2165
When calling
runAndWait
we also do notawait
. Why is that?In nodejs's tests, there is
await
The text was updated successfully, but these errors were encountered: