import self issue bug

[bluelovers]

file

./strtable.ts

import * as self from './strtable';
export default self;
console.log(__filename, require.extensions);

cli

ts-node strtable.ts

output

Expected behavior

should only once , even if .js exists

strtable.ts {
  '.ts': [Function],
  '.tsx': [Function],
  '.js': [Function],
  '.json': [Function],
  '.node': [Function] }

Actual behavior:

will load self x2 ( .js + .ts )

strtable.js { '.js': [Function],
  '.json': [Function],
  '.node': [Function],
  '.ts': [Function],
  '.tsx': [Function] }

strtable.ts { '.js': [Function],
  '.json': [Function],
  '.node': [Function],
  '.ts': [Function],
  '.tsx': [Function] }

[blakeembrey]

Can you create a reproduction I can look at? There's no way, from this information you've given me, such behaviour could be replicated.

[bluelovers]

[blakeembrey]

Still can not be replicated. I can only assume you have both a .js file and a .ts file next to each other, so this is the expected behaviour. .js has priority of .ts, so these are two distinct files and you aren't importing self, you're importing a different file.

Reference:

[bluelovers]

when we use ts-node and import , should use .ts > .js

[blakeembrey]

I disagree. Messing with core node.js expected behaviour is not something I intend to support, and having a behaviour that's different in ts-node vs tsc + node.js goes against the mission of this module.

[bluelovers]

@blakeembrey how about only if xxxx.ts already loaded, than use .ts > .js ?

[blakeembrey]

That’s still altering the behaviour of node somewhat, I would need to override the module resolution logic. Plus it wouldn’t solve anything really for you - node always loads Javascript first, so you’re just pushing the issue to the second file that’s loaded. You can replicate this by putting a file before your “self import” and it’ll show it only loads the JavaScript and never TypeScript.

[bluelovers]

how about make option?

#649

[blakeembrey]

But why?

[bluelovers]

make sure when we run .ts is new

sometime when .js, not update done or watcher fail for watch and make new .js

[blakeembrey]

I still don’t understand why. Can’t you just output JS to a different directory?

I think this has negative side effects. For example, this will create an issue for anyone writing JS libraries in TypeScript and publishing them like you are (JS next to TS). The TypeScript will be resolved first and, as a result, won’t be able to compile. Anyone using this flag might run into this random error, creating more issues to triage.

[bjg2]

I want to point out that having .js > .json > .ts > .tsx order actually messes up node expected execution, as mentioned in #786. I think correct ordering for ts-node should be: .ts > .tsx > .js > .json.

@blakeembrey I don't quite understand example above, if there are .js and .ts with the same name, which one you think should be imported? If tsc + node were executed (I guess ts-node aims to be simpler way to do tsc + node) .js would be overriden with transpiled .ts and that one would be executed. I don't think anyone expects to pick .js before .ts one, but for sure noone expects to pick .json before .ts.