Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript 2.0.0-beta bug affects some build configurations #161

Closed
cartant opened this issue Jul 16, 2016 · 2 comments
Closed

TypeScript 2.0.0-beta bug affects some build configurations #161

cartant opened this issue Jul 16, 2016 · 2 comments

Comments

@cartant
Copy link
Contributor

cartant commented Jul 16, 2016

@basarat For your reference, I've traced my TypeScript 2.0.0-beta problems to a TypeScript commit that changes the handling of source files and common and output directories. I've submitted an issue.
@cartant
Copy link
Contributor Author

cartant commented Aug 3, 2016

It seems that this is a tsify problem - not a TypeScript problem - as getCanonicalFileName is implemented in the host.

The TypeScript implementation of getCanonicalFileName simply converts the path to lower case, whereas the tsify version returns a relative path - which breaks the TypeScript 2.0 implementation of getSourceFilePathInNewDir.

@cartant cartant mentioned this issue Aug 3, 2016
Merged
@cartant
Copy link
Contributor Author

cartant commented Aug 5, 2016

This should be fixed in #171.

@cartant cartant closed this as completed Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cartant