Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header is navbar on mobile is overriding itself #2547

Closed
HarelM opened this issue Apr 15, 2024 · 3 comments · Fixed by #2548
Closed

Header is navbar on mobile is overriding itself #2547

HarelM opened this issue Apr 15, 2024 · 3 comments · Fixed by #2548
Labels
bug Functionality does not match expectation good first issue Easier issue for first time contributors help wanted Contributions are especially encouraged

Comments

@HarelM
Copy link
Contributor

HarelM commented Apr 15, 2024

Search terms

header, mobile, override

Expected Behavior

Either use ellipsis or use two rows for the header in the mobile for long text

Actual Behavior

Header is overriding itself:
image

Steps to reproduce the bug

Write a long package name I guess...?

  1. Clone: https://github.com/maplibre/ngx-maplibre-gl
  2. Run: npm ci && npm run docs
  3. open the docs (generated in dist/showcase/browser/API) and look at it using the chrome tool for mobile.

Environment

  • Typedoc version: 0.25.12
  • TypeScript version: 5.4.3
  • Node.js version: 20
  • OS: any
@HarelM HarelM added the bug Functionality does not match expectation label Apr 15, 2024
@Gerrit0 Gerrit0 added help wanted Contributions are especially encouraged good first issue Easier issue for first time contributors labels Apr 15, 2024
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Apr 15, 2024

Very unlikely that this will be fixed anytime soon unless someone else picks it up. I despise GUI work.

@HarelM
Copy link
Contributor Author

HarelM commented Apr 16, 2024

I'll be happy to contribute, can you point me in the right direction?

@HarelM HarelM mentioned this issue Apr 16, 2024
Merged
@HarelM
Copy link
Contributor Author

HarelM commented Apr 16, 2024

The part that gets overridden in the navigation links, I have proposed a solution in the link PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Functionality does not match expectation good first issue Easier issue for first time contributors help wanted Contributions are especially encouraged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

An attempt to fix issue with navigation links on mobile HarelM/typedoc
2 participants
@HarelM @Gerrit0