module.exports = [] fails with AssertionError [ERR_ASSERTION]: false == true

[jacobshirley]

Search terms

AssertionError [ERR_ASSERTION]: false == true
at Object.convertType (file:///folder/node_modules/.pnpm/typedoc@0.28.0_typescript@5.7.3/node_modules/typedoc/dist/lib/converter/types.js:128:9)
at convertType (file:///folder/node_modules/.pnpm/typedoc@0.28.0_typescript@5.7.3/node_modules/typedoc/dist/lib/converter/types.js:112:34)
at Converter.convertType (file:///folder/node_modules/.pnpm/typedoc@0.28.0_typescript@5.7.3/node_modules/typedoc/dist/lib/converter/converter.js:336:20)
at Object.convertVariable (file:///folder/node_modules/.pnpm/typedoc@0.28.0_typescript@5.7.3/node_modules/typedoc/dist/lib/converter/symbols.js:584:45)
at _convertSymbolNow (file:///folder/node_modules/.pnpm/typedoc@0.28.0_typescript@5.7.3/node_modules/typedoc/dist/lib/converter/symbols.js:113:41)
at convertSymbol (file:///folder/node_modules/.pnpm/typedoc@0.28.0_typescript@5.7.3/node_modules/typedoc/dist/lib/converter/symbols.js:126:5)
at Converter.convertSymbol (file:///folder/node_modules/.pnpm/typedoc@0.28.0_typescript@5.7.3/node_modules/typedoc/dist/lib/converter/converter.js:333:13)
at Converter.convertExports (file:///folder/node_modules/.pnpm/typedoc@0.28.0_typescript@5.7.3/node_modules/typedoc/dist/lib/converter/converter.js:444:22)
at Converter.compile (file:///folder/node_modules/.pnpm/typedoc@0.28.0_typescript@5.7.3/node_modules/typedoc/dist/lib/converter/converter.js:405:22)
at Converter.convert (file:///folder/node_modules/.pnpm/typedoc@0.28.0_typescript@5.7.3/node_modules/typedoc/dist/lib/converter/converter.js:310:18) {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: false,
expected: true,
operator: '=='
}

Expected Behavior

It should be able to process module.exports = []; as it is valid JavaScript/TypeScript.

Actual Behavior

It throws the above error.

Steps to reproduce the bug

Run typedoc on the following code:

module.exports = []

Environment

• Typedoc version: 0.28.0
• TypeScript version: 5.7.3
• Node.js version: v20.9.0
• OS: Linux

[Gerrit0]

I really wish people wouldn't do this type of thing with CommonJS... that ESM prevents it is my favorite thing about that module system.

[jacobshirley]

I really wish people wouldn't do this type of thing with CommonJS... that ESM prevents it is my favorite thing about that module system.

I agree, we have a lot of legacy code like this. Thanks for the quick fix!