Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DIST-548): Make side tab button reponsive to text #109

Merged
merged 1 commit into from
Nov 30, 2020
Merged

fix(DIST-548): Make side tab button reponsive to text #109

merged 1 commit into from
Nov 30, 2020

Conversation

antoniofull
Copy link
Contributor

  • Explain the motivation for making this change.
  • Provide a solid test plan for your changes.
  • Link to the issue - if any DIST-548

@antoniofull antoniofull requested a review from a team November 30, 2020 13:48
@cypress
Copy link

cypress bot commented Nov 30, 2020 •
edited
Loading


Test summary

106 • 0 • 0 • 0

Run details
Project embed
Status Passed
Commit cf427a6 ℹ️
Started Nov 30, 2020 4:02 PM
Ended Nov 30, 2020 4:04 PM
Duration 01:11 💡
OS Linux Ubuntu Linux - 16.04
Browser Chrome 87

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mathio
Copy link
Contributor

mathio commented Nov 30, 2020

Why so many indentation changes? Can you please revert it, its hard to review.

@antoniofull
Copy link
Contributor Author

Why so many indentation changes? Can you please revert it, its hard to review.

I formatted the code properly as it was not. Will revert those changes

fix(DIST-548): Make side tab button reponsive to text
d8a4a32 
fix(DIST-548): Make side tab button reponsive to text
@antoniofull antoniofull force-pushed the DIST-548-Make-side-tab-responsive branch from ea107b1 to d8a4a32 Compare November 30, 2020 14:24
@antoniofull
Copy link
Contributor Author

Hey @mathio should be better now, sorry for the confusion 😄

@travis-tf
Copy link

[BOT] Preview available: https://embed.typeform.com/cf427a651511971f6c3188a9f4fb66f05b0c0cac/embed.js

@antoniofull antoniofull merged commit 8c47406 into master Nov 30, 2020
@antoniofull antoniofull deleted the DIST-548-Make-side-tab-responsive branch November 30, 2020 16:19
travis-tf pushed a commit that referenced this pull request Nov 30, 2020
@semantic-release-bot
chore(release): 0.29.1 [skip ci]
168ac79 
## [0.29.1](v0.29.0...v0.29.1) (2020-11-30)

### Bug Fixes

* **DIST-548:** Make side tab button reponsive to text ([#109](#109)) ([8c47406](8c47406))
@travis-tf
Copy link

🎉 This PR is included in version 0.29.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathio mathio mathio approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antoniofull @mathio @travis-tf