fix(TU-15133): Rename ref prop to embedRef for proper typing
#657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandro-serafim
approved these changes
Jul 16, 2024
mathio
force-pushed
the
tu15133
branch
2 times, most recently
from
6a42cd8 to
5318a9c
Compare
mathio
force-pushed
the
tu15133
branch
2 times, most recently
from
1f898a8 to
c2d16e5
Compare
TypeScript adoptionCurrent adoption level: 96.4% |
This was referenced Jul 16, 2024
leandro-serafim
approved these changes
Jul 17, 2024
BREAKING CHANGE: Components are unable to access `ref` prop directly. Using `forwardRef` breaks the typings. Since we do not accept any `ForwardedRef` but rather only `MutableRefObject`, we will rename the prop to type it correctly.
Add examples for the App Router available from NextJS version >= 13.
BREAKING CHANGE: The library no longer supports node version 16 (end of life 2023-09-11). React version is bumped and requires node >= 18.
|
[BOT] Preview available with hash |
typeform-ops-gha
pushed a commit
that referenced
this pull request
Jul 17, 2024
# [@typeform/embed-v5.0.0](https://github.com/Typeform/embed/compare/@typeform/embed-v4.10.3...@typeform/embed-v5.0.0) (2024-07-17) ### Bug Fixes * **TU-15133:** Rename `ref` prop to `embedRef` for proper typing ([#657](#657)) ([7860e94](7860e94)) ### BREAKING CHANGES * **TU-15133:** Components are unable to access `ref` prop directly. Using `forwardRef` breaks the typings. Since we do not accept any `ForwardedRef` but rather only `MutableRefObject`, we will rename the prop to type it correctly. * chore(TU-15133): Update NextJS demos to run on latest version Add examples for the App Router available from NextJS version >= 13. * feat(TU-15133): Update CI to run on Node version 22 * **TU-15133:** The library no longer supports node version 16 (end of life 2023-09-11). React version is bumped and requires node >= 18.
|
🎉 This PR is included in version @typeform/embed-v5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
typeform-ops-gha
pushed a commit
that referenced
this pull request
Jul 17, 2024
# [@typeform/embed-react-v4.0.0](https://github.com/Typeform/embed/compare/@typeform/embed-react-v3.20.0...@typeform/embed-react-v4.0.0) (2024-07-17) ### Bug Fixes * **TU-15133:** Rename `ref` prop to `embedRef` for proper typing ([#657](#657)) ([7860e94](7860e94)) ### Features * Bump @typeform/embed in @typeform/embed-react package [skip ci] ([b2ada39](b2ada39)) ### BREAKING CHANGES * **TU-15133:** Components are unable to access `ref` prop directly. Using `forwardRef` breaks the typings. Since we do not accept any `ForwardedRef` but rather only `MutableRefObject`, we will rename the prop to type it correctly. * chore(TU-15133): Update NextJS demos to run on latest version Add examples for the App Router available from NextJS version >= 13. * feat(TU-15133): Update CI to run on Node version 22 * **TU-15133:** The library no longer supports node version 16 (end of life 2023-09-11). React version is bumped and requires node >= 18.
|
🎉 This PR is included in version @typeform/embed-react-v4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
refprop directly. UsingforwardRefbreaks the typings. Since we do not accept anyForwardedRefbut rather onlyMutableRefObject, we will rename the prop to type it correctly.BREAKING CHANGES:
reftoembedRefin order to type it properly