-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Proxy Usage for Downloading is broken #177
Comments
Can you try going into the Downloader tab in the settings and enabling "Safe download override"? I think the regular method might be bugged on some systems for some videos (worked fine on Windows, but reproduced the error on Ubuntu 18.04) |
I now activated "Safe download override" but now I'm back to the 429 error:
In the mean time I have set up a VPN proxy but it doesn't work:
It took me a while to figure out that I need to submit the option and its arguments as two separate options: I have no idea where the 429s come from again. I haven't downloaded anything for about 24 hours... |
Is the proxy set up at a different public IP address? If it's the same IP it'll still be blocked. If you have access to a VPN service with SOCKS5 functionality, that would be ideal. Anyways, I still need to solve the underlying "exit code 1" problem which seems unrelated to the 429 errors. I'll do some investigating on both ends tomorrow! |
Yes, the whole point of having the proxy is that the proxy is going through a VPN. So youtube is not seeing the same IP. |
Right, just making sure. You're still getting 429's? At this point it's pretty weird it hasn't gone away.. |
Today I deleted the container and rebuild it with the latest image.
This is what I got when trying to download a video (without proxy):
|
Darn youtube-dl and its useless error messages... I'm kinda lost on this one. Can you try downloading this reddit video and see if it gives you any errors? https://www.reddit.com/r/battlefield_4/comments/i4ajcd/explosive_defibrillator/ |
This may be cookies messing with your downloads (old cookies caused weird errors for me), can you see if renewing them or disabling them helps? |
In regard to the proxy issue, I can confirm that |
@adan89lion The proxy arg fails even with the safe download override enabled? |
@Tzahi12345 Proxy arg works after enabling |
@adan89lion Cool! We already have a way to force safe download mode when it recognizes args that won't work the normal way, so I went ahead and added |
im getting the same error
youtube doesnt like me and returns every request with a 429 error so i use a tor proxy |
This could simply be that youtube-dl is outdated. @vista-narvas I got the same error so at least it's reproduced. Once #234 is implemented, hopefully this will be fixed! |
it works
if i use the host name of the server for the proxy i get this error (with both youtube-dl and youtube-dlc)
its a different error youtube-dl on my pc is version 2020.09.20 and Python version 3.8.6 |
If you use SSL inspection in your network (e.g. Untangle's SSL Inspector) and it is configured to inspect youtube traffic, try disabling the SSL inspection or add a source IP address exception. This was the resolution in my case. |
i think i fixed it by adding
i have no way to verify if its using the proxy or normal connection |
@vista-narvas Interesting.. if that's the case, then the recommended method to avoid 429 errors via proxy should be to do it in the docker-compose. Good to know! |
@vista-narvas I just started looking into this last night and saw similar behavior when trying to use a SOCKS proxy. You may note in the code that there are a few places that I think updating the service to allow this via an environment variable would be trivial, so if no one else does this before I get a chance, I'll try to put together a PR sometime later this week. |
You're half-right, in that with the exec method there's no dedicated parameter for proxy. Unfortunately, you can't simply pass in the proxy as it's described in the node-youtube-dl docs, because that extra param only applies to the non-exec method, and we only use the exec method. Note that the downloadConfig is an array of args, so the current method of using a proxy is to add the proxy arg to the downloadConfig (apparently this doesn't work 100%?). This is done using the global custom args in the Downloader tab in the settings (these apply to downloads on the home page, if you want to pass custom args into subscriptions you need to use the subscription-specific custom args). This is a little bit confusing, so if you need clarification I'll be happy to help (head over to the Discussions and open a thread there). |
@Tzahi12345 You're right that this can be addressed as a custom arg through the UI. I was looking at it from the perspective of a way to do it with environment variables. Mea culpa. I did have an issue, though:
¯_(ツ)_/¯ |
@JasonGhent No problem! I think there's several ways to go about this problem, maybe I should add a dedicated setting for it since it seems used pretty often. Or I can just tell users to use the docker-compose with Docker, or custom args without Docker. Regarding your error, it looks like the args might be badly formed, or is this just a copy-paste error: It should instead be |
Blocks: #230
My 429 errors seem to be gone now, but all my downloads keep failing.
Starting with all custim arguments:
Then taking out the custom args:
And then even the cookies:
I can download the same video with youtube-dl on my windows PC in the same network without problems...
The log settings ate on debug, so I have no idea why there's not more showing up in the log.
Edit: And yes, I did restart the container.
The text was updated successfully, but these errors were encountered: