Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 1 Feedback #44

Open
negsadr opened this issue Jan 21, 2023 · 0 comments
Open

Milestone 1 Feedback #44

negsadr opened this issue Jan 21, 2023 · 0 comments

Comments

@negsadr
Copy link

negsadr commented Jan 21, 2023

Congratulations on finishing milestone 1! We can see you put a lot of work into this project, nice work!
Below we list some specific feedback you can use to improve your project.
We provide tick boxes for you to use in the future as you address these concerns to improve the final grade of your project.
If anything is unclear, please feel free to ask questions in this issue thread.


1. Team work contract (10 points)

Well done!

2. Create project structure for the python project (40 points)

Well done!

Comments:
You could have a separate section for contributors in README.md.

3. Function specifications (20 points)

Comments:
A typical docstring will include a one-line summary that does not use variable names or the function name, as well as an extended description which is missing for the functions.

4. Manage issues (10 points)

Well done!

5. Specific expectations for this milestone are: (10 points)

Well done!

6. Submission instructions (10 points)

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant