-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission: PyDataPeek (Python) #8
Comments
Package ReviewPlease check off boxes as applicable, and elaborate in the comments below. Your review is not limited to these topics, as described in the reviewer guide
DocumentationThe package includes all the following forms of documentation:
Readme requirements
The README should include, from top to bottom:
Functionality
Final approval (post-review)
Estimated hours spent reviewing: Review CommentsFeedback 1:
pip install pydatapeek --extra-index-url=https://test.pypi.org/simple/ Feedback 2:
Feedback 3:
Feedback 4 from PyDataPeek import missing_data_overview
import pandas as pd
import matplotlib.pyplot as plt
df = pd.DataFrame(
{'x1': [1.,2,3,4],
"x2": ["a","b","","d"]})
plt.show(missing_data_overview._make_plot(df)) I don't get any missing value in the plot but when I do this. from PyDataPeek import missing_data_overview
import pandas as pd
import matplotlib.pyplot as plt
df = pd.DataFrame(
{'x1': [1.,2,3,4],
"x2": ["a","b",None,"d"]})
plt.show(missing_data_overview._make_plot(df)) I start seeing the missing values. Feedback 5 In results = pd.DataFrame({'sample_record': df.iloc[1]}) Feedback 6 In the cloud generating function, I am getting the column name in the cloud name as well. Is it possible to not have it? import pandas as pd
import matplotlib.pyplot as plt
from wordcloud import WordCloud, STOPWORDS
from PyDataPeek import word_bubble
df = pd.DataFrame(
{'x1': ["play cricket","game","amazing","joke"]})
formated_words, stopwords = word_bubble._make_formated_words(df)
plt.show(word_bubble._make_cloud(formated_words, stopwords, 10, 100, 100)) |
Reviewer: Elliott Package Review
DocumentationThe package includes all the following forms of documentation:
Readme requirements
The README should include, from top to bottom:
Functionality
Final approval (post-review)
Estimated hours spent reviewing: 4 ---#### Review Comments Altogether, great job on the project. I think there is many useful features contained in the package, and it is well implemented! I found the code and structure, well written, and well documented. I found very few points to improve, but if time allowed to fix there is three things worth noting:
Thank you for your time. Thanks, Elliott |
@amank90 Thanks for your feedback. Below are some comments and updates we have made to our package based on your feedback
|
@elliott-ribner Thanks for your feedback. Below are some comments and updates we have made to our package based on your feedback.
|
Submitting Author: Monique Wong (@moniquewong), Alistair Clark (@alistair-clark) , Miro Hu (@mirohu), Thomas Pin (@MrThomasPin)
Package Name: PyDataPeek
One-Line Description of Package: Simple EDA for .csv or .xlsx documents
Repository Link: Repo Link
Version submitted:
Editor: @kvarada
Reviewer 1: Elliott Ribner @elliott-ribner
Reviewer 2: Aman Kumar Garg @amank90
Archive: TBD
Version accepted: TBD
Description
PyDataPeek is a package that enables data scientists to efficiently generate a visual summary of a dataset. This package includes functions that show the size of the dataset, a visual summary of missing data, a sample of the dataset showing the data types as well as exploratory visualizations for quantitative and qualitative data.
Scope
* Please fill out a pre-submission inquiry before submitting a data visualization package. For more info, see this section of our guidebook.
Explain how and why the package falls under these categories (briefly, 1-2 sentences):
Who is the target audience and what are scientific applications of this package?
Are there other Python packages that accomplish the same thing? If so, how does yours differ?
Several Python packages are available that support exploratory data analysis but none are specific to the targeted use cases here - a simple and technologically friendly way of summarizing data.
pandas
functionality to manipulate dataframes. Our package functionality overlaps with some functions such aspd.describe
which computes summary statistics for dataframes. The package differs in that it aims to offer summary statistics dependent on data type, including long form text data.If you made a pre-submission enquiry, please paste the link to the corresponding issue, forum post, or other discussion, or
@tag
the editor you contacted:Technical checks
For details about the pyOpenSci packaging requirements, see our packaging guide. Confirm each of the following by checking the box. This package:
Publication options
JOSS Checks
paper.md
matching JOSS's requirements with a high-level description in the package root or ininst/
.Note: Do not submit your package separately to JOSS
Are you OK with Reviewers Submitting Issues and/or pull requests to your Repo Directly?
This option will allow reviewers to open smaller issues that can then be linked to PR's rather than submitting a more dense text based review. It will also allow you to demonstrate addressing the issue via PR links.
Code of conduct
P.S. Have feedback/comments about our review process? Leave a comment here
Editor and Review Templates
Editor and review templates can be found here
The text was updated successfully, but these errors were encountered: