Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sensors breaking #7

Open
patrick-5546 opened this issue Oct 18, 2022 · 2 comments · May be fixed by UBCSailbot/raye-network-table#151
Open

Handle sensors breaking #7

patrick-5546 opened this issue Oct 18, 2022 · 2 comments · May be fixed by UBCSailbot/raye-network-table#151
Assignees
Labels
bug Something isn't working raye Raye tasks

Comments

@patrick-5546
Copy link
Member

Currently local pathfinding depends on all sensors in the global variables ACTIVE_GPS_SENSORS and ACTIVE_WIND_SENSORS working: local-pathfinding/python/ros_interface.py. What is the likelihood of a GPS or wind sensor breaking, and how can we detect this? From our latest dry land test, GPS CAN could lose signal, which would cause it to not publish new data. 3 ways to handle this come to mind:

  1. Assume this will never happen again (-_-)
  2. Only use GPS AIS (simplest solution, and we probably don't gain much accuracy by average GPS AIS and CAN anyways; we already tested that they have the same accuracy and precision)
  3. When GPS CAN is not publishing new data publish GPS AIS in the GPS CAN field

Related questions to consider

  • Are there any other ways that a sensor could break that we could easily handle?
  • Should we do this for any other sensors besides GPS CAN?
@patrick-5546 patrick-5546 added bug Something isn't working raye Raye tasks labels Oct 18, 2022
@hhenry01
Copy link
Member

  1. This would also assume that GPS AIS never fails.
  2. Assuming the GPS AIS doesn't fail, we need some way to determine if it's failing. Would something like "if the GPS CAN coordinates don't change for X seconds/minutes but the GPS AIS coordinates do, then the GPS CAN is failing" work?

@patrick-5546 patrick-5546 self-assigned this Oct 22, 2022
@patrick-5546
Copy link
Member Author

Until proven otherwise, assume GPS AIS is reliable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working raye Raye tasks
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants