-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing some top hits at higher maximum drift rates #296
Comments
It seems that as the maximum permitted drift rate (Hz/s) increases (specified by user), the minimum SNR increases in the find_doppler.py tophitsearch function, regardless of what the user/operator specified originally for the minimum SNR. E.g. Voyager 1 standard test HDF5 file from http://blpd0.ssl.berkeley.edu/Voyager_data/
The pity is that turbo_seti threw out the sideband genuine hits on Voyager 1 and kept the noise spike in the middle. It looks to me that as the max drift rate increases, so does the minimum SNR in the tophitsearch function, regardless of what the user/operator specified originally. @telegraphic |
Copying from Seti BL Slack ..... @lacker :
@telegraphic : @lacker has indeed identified the issue, and it is indeed a flaw with turboseti. At very high drift rates turboseti will also lose S/N by not frequency scrunching (averaging across channels). Combined I'd say these are the two biggest issues with turboseti. |
Describe the bug
Some top hits get deselected in function find_doppler.py tophitsearch as the maximum drift rate increases.
Relevant BL files (.fil, .h5)
To Reproduce
Steps to reproduce the behavior:
---> 3 top hits SNR
---> only 2 top hits
---> only 1 top hit
Expected behavior
All 3 cases should produce the same 3 top hits.
The text was updated successfully, but these errors were encountered: