Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signup creating cognito user before sms verification #104

Open
acholyn opened this issue Oct 11, 2024 · 1 comment
Open

signup creating cognito user before sms verification #104

acholyn opened this issue Oct 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@acholyn
Copy link
Collaborator

acholyn commented Oct 11, 2024

We call the signUp() function on the sign up form and a cognito user is being created before they respond to the sms - noticed because we're currently unable to receive sms messages. In the lambda console we have a pre-signup thing, possibly it's something to do with this?

We probably need a new function that will just send a code without trying to init auth and then if they verify it we can sign them up and automatically authenticate them

@acholyn acholyn added the bug Something isn't working label Oct 11, 2024
@tcouch
Copy link
Collaborator

tcouch commented Oct 15, 2024

At the moment the pre-signup Lambda is automatically confirming the user and validating their number (I think that's just what whatever tutorial I was following did). I think really we want to add new users to the pool when they try to sign up, but not confirm them until they've passed the SMS challenge. If they try to sign up again later we should check if they're confirmed rather than if they exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants