Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate RepoCommandParam into ObjCommandParam and SyncCommandParam #102

Open
yoursunny opened this issue Dec 31, 2024 · 0 comments
Open

Separate RepoCommandParam into ObjCommandParam and SyncCommandParam #102

yoursunny opened this issue Dec 31, 2024 · 0 comments

Comments

@yoursunny
Copy link
Contributor

In Specification - Encoding:

The insert topic only accepts RepoCommandParam that contains ObjParam.
The sync/join topic only accepts RepoCommandParam that contains SyncParam.
This suggests that these should be two separate types: ObjCommandParam and SyncCommandParam.

See #101 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yoursunny