Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable MNL coefficient bounds #116

Open
smmaurer opened this issue Oct 11, 2019 · 0 comments
Open

Configurable MNL coefficient bounds #116

smmaurer opened this issue Oct 11, 2019 · 0 comments

Comments

@smmaurer
Copy link
Member

In the MNL estimation code there are bounds set on the coefficient values, i guess so that unstable models will converge on something. The bounds are set at (-3, 3) in the older UrbanSim codebase, and (-1000, 1000) in ChoiceModels.

https://github.com/UDST/urbansim/blob/master/urbansim/urbanchoice/mnl.py#L178
https://github.com/UDST/choicemodels/blob/master/choicemodels/mnl.py#L589
https://docs.scipy.org/doc/scipy/reference/generated/scipy.optimize.fmin_l_bfgs_b.html

We should make this configurable from a higher level, like in the model template estimation settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant