-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings objects for groups of common parameters #54
Labels
Comments
Just popping in here to say that I like this a lot. |
Closed
This was referenced Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As we incorporate more choice table and simulation flexibility (weights, interaction terms, etc), the number of settings parameters for model steps is growing quickly. MNL already has 20, and could easily push 30! This makes it harder for users to understand where to start, and how the parameters are related to each other. It's also not ideal on the back end.
Proposal
I'd like to start grouping together related parameters, so that we have a bundle that represents an estimation choice table, a bundle that represents a simulation choice table, a bundle that represents other simulation settings, and on on. These would be represented behind the scenes by settings classes that would make it easier to share functionality among templates.
Here's a rough diagram for an MNL model step:
The model step API would shift a bit, something like this:
More verbose, but hopefully clearer how the pieces are related.
The text was updated successfully, but these errors were encountered: