Replies: 4 comments 14 replies
-
|
I would definitely be in favour of simplifying the code as much as possible and combining cards that fulfil the same function. But then we also have to think about how to deal with the legacy stuff. But that should be solvable |
Beta Was this translation helpful? Give feedback.
-
|
Indeed maybe it is better to separate them thad way you can more easily make device specific changes as example withe the fan adding humidity and temperature |
Beta Was this translation helpful? Give feedback.
-
|
Well, it could be a solution to create a new card What do you think? |
Beta Was this translation helpful? Give feedback.
-
|
I think we make each standard card as multipurpose as possible. In this example we could provide a JS-template which can recognize based on the brightness or fan speed attribute of the entity what te needed functions are. Another way is to add a variable were you can specify the type of entity. Than this variable can unlock type specific functions through soms if/else statements. But the nicest solution is to let the templates in the card auto choose his functions based on the type of entity or attributes available. This means less inconvenience for new and simple users. |
Beta Was this translation helpful? Give feedback.
-
|
I'm in favor of simplifying the structure and make it easy to extend the base cards with the functionallity i want. In most cases i tend to copy the base card and then modify what I want. But in the long run this is not sustainable. Things i have changed is the highlight color and the state value when the card should be highlighted. Not all sensor return on/off. |
Beta Was this translation helpful? Give feedback.
-
|
I am coming back on this topic because we are seeing thad if people want to make little changes thad they make or need to make custom cards
I am busy making a Figma withe all the options we are seeing on the Home Assistant community and on the Github. so I am asking for more ideas an suggestions how to go about making the base for the cards |
Beta Was this translation helpful? Give feedback.
-
in my opinion the language files should remain inside the folder of each card. An external file will merge these files to avoid problems with missing languages. |
Beta Was this translation helpful? Give feedback.
-
|
I don't really see any advantage in creating separate language files for each card. This way you have everything in one place and only have to maintain the language files once. This also makes it much easier for the cards to use overlapping language variables. Since it is much easier to see which translations already exist. And for people who want to contribute to the translation, it also makes it easier, because they only have to translate one file. |
Beta Was this translation helpful? Give feedback.
-
|
@CM000n I think this approach is the way the project needs to go. If we keep the naming of the cards and templates the same it doesn't lead to breaking changes. I do think all translations of a language should be in one file for each language. As adding language files for each card can lead to more bugs (due to duplicates in naming for instance) and more copying work by updating your system directory for as long this project is not HACS compatible. |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
yes, right, it produces more bugs. I didn't think about it. |
Beta Was this translation helpful? Give feedback.
-
|
Hi guys, I didn't see all these interesting discussions opened ! PS : @CM000n : you forgot the popup folder :-p |
Beta Was this translation helpful? Give feedback.
-
|
I've just started using this "theme" and am in enjoying it. Just to offer a bit of my opinion. I think separating custom cards into their own repository (just one repo with all the cards kind of like how the folder is now) might be a good thing. Keep the base repository as clean as possible. Cards can always be "promoted" from custom cards to be official/base cards if the team decides they should be. I have no idea how splitting things would impact potentials HACS installations. |
Beta Was this translation helpful? Give feedback.
-
When designing some cards in Figma I noticed that some cards are direct duplicates of other cards only the name and some text.
like:
Just a icon change
Withe the newer cards it is already in unnecessary to make a different card because the icon is taken form the entity,
but the card is named light_slider??
So maybe we can make just a card_slider withe more options
Beta Was this translation helpful? Give feedback.
All reactions