Skip to content

Commit 95d36c6

Browse files
authored
docs(playground): substitute combobox with select in filters (#53)
1 parent 2449909 commit 95d36c6

File tree

2 files changed

+32
-35
lines changed

2 files changed

+32
-35
lines changed

packages/playground/webapp/css/style.css

Lines changed: 26 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,11 @@
5555
background-color: #fff !important;
5656
}
5757

58+
/* Fix flickering behaviour of Action list items */
59+
.side-links .sapMLIB {
60+
padding: 0;
61+
}
62+
5863
.hcb .side-links {
5964
background-color: #000 !important;
6065
color: #fff !important;
@@ -86,7 +91,7 @@ html.sap-desktop .hcb .side-links .links-list .sapMList .sapMLIB.sapMALI:not(.sa
8691

8792
.side-links .links-list .sapMALIText {
8893
text-align: left;
89-
padding-left: 2rem;
94+
padding-left: 2rem !important;
9095
}
9196

9297
.side-links .links-list .sapMALIText:not(.sapMLIBActive){
@@ -255,7 +260,7 @@ html.sap-desktop .sapContrast .sapMLnk:focus:not(.sapMLnkDsbl) {
255260
}
256261

257262
.switch-container {
258-
background-color: #222222 !important;
263+
background-color: #222 !important;
259264
height: 14.19rem !important;
260265
padding: 0 3rem;
261266
}
@@ -268,35 +273,32 @@ html.sap-desktop .sapContrast .sapMLnk:focus:not(.sapMLnkDsbl) {
268273
color: white !important;
269274
}
270275

271-
.switch-container .sapMInputBaseContentWrapper.sapMInputBaseHasEndIcons, .sapMInputBaseContentWrapper.sapMInputBaseHasEndIcons {
272-
background-color: #222;
273-
border-radius: 2px;
274-
border-color: #fff;
275-
border: 1px solid #fff;
276+
277+
/* Change Select default styles */
278+
.switch-container .select-width.sapMSlt.sapMSltDefault.sapMSltHoverable.sapMSltMinWidth.sapMSltWithArrow {
279+
background-color: #000;
276280
}
277281

278-
.switch-container .sapMInputBaseContentWrapper.sapMInputBaseHasEndIcons:hover,
279-
.switch-container .sapMInputBaseIconPressed.sapMInputBaseIcon,
280-
.switch-container .sapMInputBaseIconPressed .sapMInputBaseContentWrapper:not(.sapMInputBaseReadonlyWrapper):not(.sapMInputBaseContentWrapperState):not(.sapMInputBaseDisabledWrapper) {
281-
background-color: #000 !important;
282-
border-color: #fff !important;
282+
.switch-container .select-width.sapMSlt.sapMSltDefault.sapMSltHoverable.sapMSltMinWidth.sapMSltWithArrow:hover,
283+
.switch-container .sapMSltPressed:not(.sapMSltDisabled):not(.sapMSltState) {
284+
border-color: #fff;
283285
}
284286

285-
.switch-container .sapMComboBoxInner.sapMInputBaseInner {
286-
color: #fff !important;
287+
.switch-container .sapMSltArrow {
288+
color: #fff;
289+
background-color: #000;
287290
}
288291

289-
.switch-container .sapMComboBox .sapMInputBaseIcon.sapUiIcon.sapUiIconMirrorInRTL.sapUiIconPointer {
290-
color: #fff !important;
292+
.switch-container .sapMSelectListItemText {
293+
color: #fff;
291294
}
292295

293-
.switch-container .sapMInputBaseIcon:active,
294-
.switch-container .sapMInputBaseIconPressed .sapMInputBaseIcon,
295-
html.sap-desktop .switch-container .sapMInputBaseIconPressed .sapMInputBaseIcon:hover{
296-
background-color: transparent;
296+
.switch-container .sapMSltPressed > .sapMSltArrow {
297+
background-color: #222;
297298
}
299+
/* End of Select restyling */
298300

299-
/* Override ComboBox Suggestions color */
301+
/* Override Select Suggestions color */
300302
/* NB! Will affect all checkboxes! */
301303
.sapMSelectListItem {
302304
background-color: #000 !important;
@@ -313,7 +315,7 @@ html.sap-desktop .switch-container .sapMInputBaseIconPressed .sapMInputBaseIcon:
313315
display: flex !important;
314316
align-items: center;
315317
justify-content: center;
316-
background-color: #222222 !important;
318+
background-color: #222 !important;
317319
}
318320

319321
.settings-button > span {
@@ -331,17 +333,12 @@ html.sap-desktop .switch-container .sapMInputBaseIconPressed .sapMInputBaseIcon:
331333
color: #fff !important;
332334
}
333335

334-
.settings-button .sapMBtnActive {
335-
/* background-color: #fff !important;
336-
color: #000 !important; */
337-
}
338-
339336
.settings-buttons-wrapper .sapMBtnContent {
340337
color: #fff !important;
341338
}
342339

343-
.combobox-width {
344-
width: 20rem;
340+
.select-width {
341+
width: 20rem !important;
345342
}
346343

347344
.ui5-logo {

packages/playground/webapp/view/Main.view.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,27 +50,27 @@
5050
<FlexBox width="100%" justifyContent="SpaceBetween" wrap="Wrap">
5151
<FlexBox direction="Column">
5252
<Label text="Theme" labelFor="theme-cb"/>
53-
<ComboBox class="combobox-width" id="theme-cb" selectedKey="sap_fiori_3">
53+
<Select class="select-width" id="theme-cb" selectedKey="sap_fiori_3">
5454
<core:Item key="sap_fiori_3" text="Fiori 3" />
5555
<core:Item key="sap_belize_hcb" text="High Contrast Black" />
5656
<core:Item key="sap_belize" text="Belize" />
57-
</ComboBox>
57+
</Select>
5858
</FlexBox>
5959

6060
<FlexBox direction="Column">
6161
<Label text="Content Density" labelFor="content-density-cb"/>
62-
<ComboBox class="combobox-width" id="content-densit-cb" selectedKey="false">
62+
<Select class="select-width" id="content-densit-cb" selectedKey="false">
6363
<core:Item key="false" text="Cozy" />
6464
<core:Item key="true" text="Compact" />
65-
</ComboBox>
65+
</Select>
6666
</FlexBox>
6767

6868
<FlexBox direction="Column">
6969
<Label text="Text Direction" labelFor="direction-cb"/>
70-
<ComboBox class="combobox-width" id="direction-cb" selectedKey="false">
70+
<Select class="select-width" id="direction-cb" selectedKey="false">
7171
<core:Item key="false" text="LTR" />
7272
<core:Item key="true" text="RTL" />
73-
</ComboBox>
73+
</Select>
7474
</FlexBox>
7575
</FlexBox>
7676

0 commit comments

Comments
 (0)