Skip to content

Commit de73d48

Browse files
pskelinpskelin
authored
chore: restore failing tests correctly (#6938)
1 parent 2355afc commit de73d48

File tree

1 file changed

+57
-43
lines changed

1 file changed

+57
-43
lines changed

‎packages/main/test/specs/DateRangePicker.spec.js‎

Lines changed: 57 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -51,40 +51,54 @@ describe("DateRangePicker general interaction", () => {
5151
await daterangepicker.keys("Enter");
5252
});
5353

54-
// it("startDateValue and endDateValue getter", async () => {
55-
// await browser.url(`test/pages/DateRangePicker.html`);
56-
// const daterangepicker = await browser.$("#daterange-picker4");
54+
it("startDateValue and endDateValue getter", async () => {
55+
await browser.url(`test/pages/DateRangePicker.html`);
56+
const daterangepicker = await browser.$("#daterange-picker4");
57+
58+
await daterangepicker.click();
59+
await browser.keys("27/09/2019 - 10/10/2019");
60+
await browser.keys("Enter");
61+
62+
await daterangepicker.waitForClickable({ timeout: 1000 });
63+
const res = await browser.executeAsync(done => {
64+
const myDRP = document.getElementById("daterange-picker4");
65+
const startDateValue = myDRP.startDateValue.getTime();
66+
const endDateValue = myDRP.endDateValue.getTime();
67+
68+
done({startDateValue, endDateValue});
69+
});
5770

58-
// await daterangepicker.click();
59-
// await browser.keys("27/09/2019 - 10/10/2019");
60-
// await browser.keys("Enter");
71+
assert.deepEqual(new Date(res.startDateValue), new Date(2019, 8, 27), "The first date is in JS Date format");
72+
assert.deepEqual(new Date(res.endDateValue), new Date(2019, 9, 10), "The last date is JS Date format");
73+
});
6174

62-
// await daterangepicker.waitForClickable({ timeout: 1000 });
63-
// const res = await browser.executeAsync(done => {
64-
// const myDRP = document.getElementById("daterange-picker4");
65-
// const startDateValue = myDRP.startDateValue;
66-
// const endDateValue = myDRP.endDateValue;
75+
it("Initially setting the same date as first & last is possible", async () => {
76+
const res = await browser.executeAsync(done => {
77+
const myDRP = document.getElementById("daterange-picker5");
78+
const startDateValue = myDRP.startDateValue.getTime();
79+
const endDateValue = myDRP.endDateValue.getTime();
6780

68-
// done({startDateValue, endDateValue});
69-
// });
81+
done({startDateValue, endDateValue});
82+
});
7083

71-
// assert.deepEqual(new Date(res.startDateValue), new Date(2019, 8, 27), "The first date is in JS Date format");
72-
// assert.deepEqual(new Date(res.endDateValue), new Date(2019, 9, 10), "The last date is JS Date format");
73-
// });
84+
assert.deepEqual(new Date(res.startDateValue), new Date(res.endDateValue), "Initially properties are set correctly");
85+
});
7486

75-
// it("Initially setting the same date as first & last is possible", async () => {
76-
// const daterangepicker = await browser.$("#daterange-picker5");
87+
it("Setting the same date as first & last is possible", async () => {
88+
const daterangepicker = await browser.$("#daterange-picker5");
7789

78-
// assert.strictEqual(await daterangepicker.getProperty("startDateValue"), await daterangepicker.getProperty("endDateValue"), "Initially properties are set correctly");
79-
// });
90+
await daterangepicker.setProperty("value", "Aug 5, 2020 - Aug 5, 2020");
8091

81-
// it("Setting the same date as first & last is possible", async () => {
82-
// const daterangepicker = await browser.$("#daterange-picker5");
92+
const res = await browser.executeAsync(done => {
93+
const myDRP = document.getElementById("daterange-picker5");
94+
const startDateValue = myDRP.startDateValue.getTime();
95+
const endDateValue = myDRP.endDateValue.getTime();
8396

84-
// await daterangepicker.setProperty("value", "Aug 5, 2020 - Aug 5, 2020");
97+
done({startDateValue, endDateValue});
98+
});
8599

86-
// assert.strictEqual(await daterangepicker.getProperty("startDateValue"), await daterangepicker.getProperty("endDateValue"), "Properties are set correctly");
87-
// })
100+
assert.deepEqual(new Date(res.startDateValue), new Date(res.endDateValue), "Properties are set correctly");
101+
})
88102

89103
it("Change event fired once", async () => {
90104
const staticAreaItemClassName = await browser.getStaticAreaItemClassName("#daterange-picker1");
@@ -215,26 +229,26 @@ describe("DateRangePicker general interaction", () => {
215229
assert.strictEqual(monthButton.innerHTML, monthName, "The month is not changed after selecting the first date in the future");
216230
});
217231

218-
// it("startDateValue and endDateValue getters when single value", async () => {
219-
// await browser.url(`test/pages/DateRangePicker.html`);
220-
// const daterangepicker = await browser.$("#daterange-picker4");
232+
it("startDateValue and endDateValue getters when single value", async () => {
233+
await browser.url(`test/pages/DateRangePicker.html`);
234+
const daterangepicker = await browser.$("#daterange-picker4");
221235

222-
// await daterangepicker.click();
223-
// await browser.keys("27/09/2019");
224-
// await browser.keys("Enter");
236+
await daterangepicker.click();
237+
await browser.keys("27/09/2019");
238+
await browser.keys("Enter");
225239

226-
// await daterangepicker.waitForClickable({ timeout: 1000 });
227-
// const res = await browser.executeAsync(done => {
228-
// const myDRP = document.getElementById("daterange-picker4");
229-
// const startDateValue = myDRP.startDateValue;
230-
// const endDateValue = myDRP.endDateValue;
231-
// const drpValue = myDRP.value;
240+
await daterangepicker.waitForClickable({ timeout: 1000 });
241+
const res = await browser.executeAsync(done => {
242+
const myDRP = document.getElementById("daterange-picker4");
243+
const startDateValue = myDRP.startDateValue.getTime();
244+
const endDateValue = myDRP.endDateValue.getTime();
245+
const drpValue = myDRP.value;
232246

233-
// done({startDateValue, endDateValue, drpValue});
234-
// });
247+
done({startDateValue, endDateValue, drpValue});
248+
});
235249

236-
// assert.deepEqual(new Date(res.startDateValue), new Date(2019, 8, 27), "First date is correct");
237-
// assert.equal(res.endDateValue, null, "Second date is correct");
238-
// assert.equal(res.drpValue, await (await browser.$("#labelDate")).getHTML(false), "Event value is correct");
239-
// });
250+
assert.deepEqual(new Date(res.startDateValue), new Date(2019, 8, 27), "First date is correct");
251+
assert.equal(res.endDateValue, null, "Second date is correct");
252+
assert.equal(res.drpValue, await (await browser.$("#labelDate")).getHTML(false), "Event value is correct");
253+
});
240254
});

0 commit comments

Comments
 (0)