Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing py.typed marker #1723

Closed
SimonSchick opened this issue Oct 13, 2022 · 3 comments · Fixed by #2724
Closed

Missing py.typed marker #1723

SimonSchick opened this issue Oct 13, 2022 · 3 comments · Fixed by #2724

Comments

@SimonSchick
Copy link

It seems the package is very well typed, you should consider adding the py.typed marker in accordance to https://peps.python.org/pep-0561/
@jamesbraza jamesbraza mentioned this issue Feb 29, 2024
Closed
@rjurney
Copy link

rjurney commented Apr 28, 2024

This would be great.

@mehrdadh
Copy link

+1

@tomaarsen
Copy link
Collaborator

Hello!

I haven't used mypy in a few years, and I'm not very familiar with these py.typed files. I see that one needs to be created & included in the built package, but I'm unsure what it does. Could someone elaborate?

Also, I'm open to a PR on this matter.

  • Tom Aarsen

@tomaarsen tomaarsen linked a pull request Jun 6, 2024 that will close this issue
[typing] Improve typing for many functions & add py.typed to satisfy mypy #2724
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rjurney @SimonSchick @mehrdadh @tomaarsen