Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better error pages #119

Open
ChandlerSwift opened this issue Jan 31, 2021 · 2 comments
Open

Add better error pages #119

ChandlerSwift opened this issue Jan 31, 2021 · 2 comments

Comments

@ChandlerSwift
Copy link
Member

In many cases, when a 401, 403, or 404 should be presented, a non-formatted and not-very-helpful error page is shown.

For example, here's an attack that doesn't exist:
20210131_15h58m05s_grim

These should be formatted nicely, and contain helpful text where possible. Using get_or_404 may get us a lot of the way there, in combination with a nice 404 page.

@ChandlerSwift
Copy link
Member Author

@jnowaczek
Copy link
Member

PR #130 includes 404 handlers for teams and attacks. I wasn't sure what situations might cause 401s, 403s, or other 404s so I chose not to add Flask app wide handlers since they wouldn't have any helpful information in them. Are there cases where these other errors occur?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants