Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WADO-RS: Skip file parsing for faster reads #11

Open
nickamzol opened this issue Jul 4, 2024 · 0 comments
Open

WADO-RS: Skip file parsing for faster reads #11

nickamzol opened this issue Jul 4, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request service:wado-rs This issue affects the WADO-RS service

Comments

@nickamzol
Copy link
Member

Do we really need to parse every DICOM file before sending them to the client?
I think we can just pass through the raw data (Vec<u8>), unless we want to change some attributes (is there some kind of lazy parsing in dicom-rs so we do not need to parse the entire file?).

Maybe introduce a new config option validate: <false|true>, as validation of data before sending seems like a good idea?

@nickamzol nickamzol added enhancement New feature or request service:wado-rs This issue affects the WADO-RS service labels Jul 4, 2024
@nickamzol nickamzol self-assigned this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request service:wado-rs This issue affects the WADO-RS service
Projects
None yet
Development

No branches or pull requests

1 participant