Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use new FatalErrorWithLog #102

Open
andrewj-brown opened this issue Apr 25, 2023 · 2 comments
Open

use new FatalErrorWithLog #102

andrewj-brown opened this issue Apr 25, 2023 · 2 comments
Labels
enhancement update an existing command or cog for some new functionality good first issue Good for newcomers

Comments

@andrewj-brown
Copy link
Member

SB2.0 (#75) includes a brand-spanking-new exception, FatalErrorWithLog. Implemented as part of utils, it's an exception for bad internal states or other code-based failures. Importantly, the exception comes with a logging system that sends its exception message to #admin-alerts.

Because logging internal failures to #admin-alerts is significantly more useful than the existing Azure log trace, all the rest of UQCSBot's code should be reviewed for cases where FatalErrorWithLog should be used (or even extended by further custom exceptions) to log errors.
@andrewj-brown andrewj-brown added enhancement update an existing command or cog for some new functionality good first issue Good for newcomers labels Apr 25, 2023
@andrewj-brown andrewj-brown changed the title use new (to-be-merged) FatalErrorWithLog use new FatalErrorWithLog May 10, 2023
@andrewj-brown
Copy link
Member Author

andrewj-brown commented May 10, 2023 •
edited
Loading

FatalErrorWithLog is now live (wahey!), but only used in Starboard (awww).

@49Indium
Copy link
Member

Haiku detection now uses FatalErrorWithLog. I'll go through some other commands soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement update an existing command or cog for some new functionality good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@49Indium @andrewj-brown