Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we be using cwms-python? #24

Open
krowvin opened this issue May 6, 2024 · 1 comment
Open

Should we be using cwms-python? #24

krowvin opened this issue May 6, 2024 · 1 comment
Labels

Comments

@krowvin
Copy link
Collaborator

krowvin commented May 6, 2024

I was working on the levels and adding those.
(We have something custom, but I'm thinking I'll create an issue and try to submit something for this)

While they do not exist in cwms-python yet to my knowledge, they will eventually.

It looks like we are using URL lib under the hood and have full control over the responses for Timeseries.

In my opinion, the cmws-python library would add more dependencies to this project. But it is a consistent way to fetch the data against the API.

My vote would be no, but I'm curious if everyone else feels that way

@MikeNeilson
Copy link
Collaborator

It's arguable, but cwms-python didn't exist at the time of writing this initially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants